LGTM with a nit. ================ Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:252 @@ -251,3 +251,3 @@ const StringRef Pattern = Name; if (Pattern.startswith("::")) { return FullName == Pattern; ---------------- You can drop the {} too now. http://reviews.llvm.org/D5826