[PATCH] [clang-tidy] Add support for custom configuration file names/formats.

Daniel Jasper djasper at google.com
Thu Oct 16 05:15:40 PDT 2014


================
Comment at: clang-tidy/ClangTidyOptions.h:126
@@ +125,3 @@
+                                     llvm::StringRef)>> ConfigHandler;
+  typedef std::vector<ConfigHandler> ConfigFileHandlers;
+
----------------
I think the naming here is quite confusing:

1. ConfigHandler: A single handler
2. ConfigFileHandlers: Multiple handlers
3. ConfigHandlers: Member variable containing the current ConfigFileHandlers

I suggest swappin #2 and #3 or renaming ConfigHandler to ConfigFileHandler.

http://reviews.llvm.org/D5821






More information about the cfe-commits mailing list