[PATCH] [clang-tidy] Move some of the misc checks to readability/

Daniel Jasper djasper at google.com
Wed Oct 15 02:33:05 PDT 2014


================
Comment at: clang-tidy/misc/CMakeLists.txt:18
@@ -20,2 +17,3 @@
   clangTidy
+  clangTidyReadability
   )
----------------
Hm. I understand that you don't want to create a separate readability at this point. But leave a comment here, otherwise the layering seems quite confusing.

================
Comment at: clang-tidy/readability/BracesAroundStatementsCheck.h:10
@@ -9,3 +9,3 @@
 
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_BRACES_AROUND_STATEMENTS_CHECK_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_BRACES_AROUND_STATEMENTS_CHECK_H
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_BRACESAROUNDSTATEMENTSCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_BRACESAROUNDSTATEMENTSCHECK_H
----------------
Not sure whether this is allowed/desired for LLVM style, but we should fix the comment on the #endif accordingly.

================
Comment at: clang-tidy/readability/FunctionSize.h:48
@@ -45,2 +47,2 @@
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_FUNCTIONSIZE_H
----------------
Fix comment.

================
Comment at: clang-tidy/readability/RedundantSmartptrGet.h:37
@@ -34,3 +36,3 @@
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_REDUNDANT_SMARTPTR_GET_H
 
----------------
Same here.

http://reviews.llvm.org/D5792






More information about the cfe-commits mailing list