[PATCH] [complex] Teach the complex math IR gen to emit direct math and a NaN-test prior to the call to the library function.

hfinkel at anl.gov hfinkel at anl.gov
Tue Oct 14 18:21:54 PDT 2014


================
Comment at: lib/CodeGen/CGExprComplex.cpp:608
@@ +607,3 @@
+    return "__mulxc3";
+  }
+}
----------------
chandlerc wrote:
> hfinkel wrote:
> > What about PPC_FP128TyID, which gets __multc3 (or FP128TyID, which I think also gets __mulxc3)?
> That's not new in this patch. I've only really been able to test this effectively on x86, and am not super familiar with the PPC ABI here.
> 
> Want to add multc3 and PPC_FP128TyID and a powerpc triple run to the test? It should probably be a separate commit though.
Okay. What pronoun belongs in front of the 'want'?

http://reviews.llvm.org/D5756






More information about the cfe-commits mailing list