[PATCH] Make analyzer check all argument for nonnull attribute

Jordan Rose jordan_rose at apple.com
Mon Oct 13 12:48:43 PDT 2014


Thanks, Daniel, this looks great. Committed as r219625.

Jordan

On Oct 13, 2014, at 8:08 , Daniel Fahlgren <daniel at fahlgren.se> wrote:

> Hi Jordan,
> 
> On Tue, 2014-10-07 at 18:03 -0700, Jordan Rose wrote:
>> Hi, Daniel. This is very simple, but I feel like we might as well do
>> this nicely by tracking a set of which parameters are marked non-null
>> by function-level attributes. llvm::SmallBitVector might be an easy way
>> to do that, or even just a sorted SmallVector of indices.
> 
> That for reviewing this. I've updated the patch to use SmallBitVector
> now and it all turned out quite clean. Any thoughts or comments?
> 
>> (Thanks for doing the performance test. I believe that there's no
>> noticeable cost right now. However, it still feels like a code smell
>> that I'd rather not leave in.)
> 
> Cheers,
> Daniel
> <nonnull.patch>




More information about the cfe-commits mailing list