[PATCH] Partial specialization after class template instantiation.
Anton Bikineev
ant.bikineev at gmail.com
Mon Oct 13 06:36:14 PDT 2014
In case const auto * deduced type has different meaning (pointer to constant), so it doesn’t compile.
On Oct 13, 2014, at 9:16 AM, Nikola Smiljanić <popizdeh at gmail.com> wrote:
> It looks good ignoring two style nitpicks. I'll have more confidence when you add the test for this, code review can stay open until you get to it.
>
> ================
> Comment at: lib/Sema/SemaTemplate.cpp:6226
> @@ +6225,3 @@
> + if (isPartialSpecialization) {
> + auto *const ThisPartialSpec =
> + static_cast<ClassTemplatePartialSpecializationDecl *>(Specialization);
> ----------------
> const auto *
>
> ================
> Comment at: lib/Sema/SemaTemplate.cpp:6234
> @@ +6233,3 @@
> + !DeduceTemplateArguments(ThisPartialSpec, S->getTemplateArgs(), Info)) {
> + auto *const InstantiatedFrom =
> + S->getInstantiatedFrom()
> ----------------
> Same here.
>
> http://reviews.llvm.org/D5744
>
>
More information about the cfe-commits
mailing list