r219561 - Fix deserialization of PredefinedExpr in dependent context.

[Bataev, Alexey]

Hi, added test for the r219561 in r219594.

Best regards,
Alexey Bataev
=============
Software Engineer
Intel Compiler Team

13.10.2014 7:40, David Blaikie пишет:
> Generally test cases are committed with the fix - makes it easier when 
> spelunking through revision history (for the code that applies to a 
> fix/test/etc).
>
> It helps to mention the reason a test is omitted (urgency, test case 
> reduction is difficult, etc) and whether one will be forthcoming in 
> the commit message.
>
> If you could reply to this review thread with the revision where the 
> test is added (when it is added), that'd be great!
>
> - David
>
> On Sun, Oct 12, 2014 at 7:45 PM, Bataev, Alexey <a.bataev at hotmail.com 
> <mailto:a.bataev at hotmail.com>> wrote:
>
>     Yes, I'm working on it. Will be ready soon.
>
>     Best regards,
>     Alexey Bataev
>     =============
>     Software Engineer
>     Intel Compiler Team
>
>     13.10.2014 <tel:13.10.2014> 4:31, David Blaikie пишет:
>
>
>         Any chance of a test?
>
>         On Oct 10, 2014 10:21 PM, "Alexey Bataev"
>         <a.bataev at hotmail.com <mailto:a.bataev at hotmail.com>
>         <mailto:a.bataev at hotmail.com <mailto:a.bataev at hotmail.com>>>
>         wrote:
>
>             Author: abataev
>             Date: Sat Oct 11 00:07:24 2014
>             New Revision: 219561
>
>             URL: http://llvm.org/viewvc/llvm-project?rev=219561&view=rev
>             Log:
>             Fix deserialization of PredefinedExpr in dependent context.
>
>             Modified:
>                 cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
>
>             Modified: cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
>             URL:
>         http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderStmt.cpp?rev=219561&r1=219560&r2=219561&view=diff
>            
>         ==============================================================================
>             --- cfe/trunk/lib/Serialization/ASTReaderStmt.cpp (original)
>             +++ cfe/trunk/lib/Serialization/ASTReaderStmt.cpp Sat Oct 11
>             00:07:24 2014
>             @@ -423,7 +423,7 @@ void ASTStmtReader::VisitPredefinedExpr(
>                VisitExpr(E);
>                E->setLocation(ReadSourceLocation(Record, Idx));
>                E->Type = (PredefinedExpr::IdentType)Record[Idx++];
>             -  E->FnName = cast<StringLiteral>(Reader.ReadSubExpr());
>             +  E->FnName =
>         cast_or_null<StringLiteral>(Reader.ReadSubExpr());
>              }
>
>              void ASTStmtReader::VisitDeclRefExpr(DeclRefExpr *E) {
>
>
>             _______________________________________________
>             cfe-commits mailing list
>         cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>         <mailto:cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>>
>         http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>