[PATCH] [OPENMP] Codegen for 'firstprivate' clause in 'parallel' directive

[Alexey Bataev]

Hal, Thanks for the review!

================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:128
@@ +127,3 @@
+  }
+
+}
----------------
hfinkel wrote:
> Extra line.
Removed

================
Comment at: lib/Sema/SemaOpenMP.cpp:3381
@@ +3380,3 @@
+    // original variable. The address of the original variable is replaced by
+    // the address of the new private variable in the CodeGen.This new variable
+    // is not added to IdResolver, so the code in the OpenMP region uses
----------------
hfinkel wrote:
> Missing space before "This".
Fixed.

================
Comment at: lib/Sema/SemaOpenMP.cpp:3386
@@ +3385,3 @@
+    // For arrays generate initializer for single element and replace it by the
+    // original array element on the CodeGen.
+    if (DE->getType()->isArrayType()) {
----------------
hfinkel wrote:
> on the CodeGen -> in CodeGen
Fixed.

================
Comment at: test/OpenMP/for_firstprivate_messages.cpp:222
@@ -221,2 +221,3 @@
 #pragma omp parallel
+
 #pragma omp for firstprivate(xa) // OK
----------------
hfinkel wrote:
> Extra newline?
Removed

http://reviews.llvm.org/D5140