[PATCH] [OPENMP] Codegen for threadprivate variables

hfinkel at anl.gov hfinkel at anl.gov
Tue Oct 7 06:47:37 PDT 2014


LGTM.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:1413
@@ +1412,3 @@
+  if (const auto *VD = dyn_cast<VarDecl>(D)) {
+    EmitGlobalVarDefinition(VD);
+    if (getLangOpts().OpenMP && getOpenMPRuntime().isOMPThreadPrivateDecl(VD))
----------------
We should add a comment here explaining the separation of concerns between what EmitGlobalVarDefinition does, what EmitOMPThreadPrivateVarDecl does, and why they're both called here).

http://reviews.llvm.org/D4002






More information about the cfe-commits mailing list