[PATCH] [OPENMP] Codegen for 'private' clause in 'parallel' directive

hfinkel at anl.gov hfinkel at anl.gov
Tue Oct 7 06:01:01 PDT 2014


LGTM, thanks! (obviously there is some overlap with D5140, you might want to factor out the common pieces and commit them first -- just note in the commit message that tests will follow in the subsequent commits).

================
Comment at: lib/Sema/SemaOpenMP.cpp:3137
@@ +3136,3 @@
+    // value. The address of the original variable is replaced by the address of
+    // the new private variable in the CodeGen.This new variable is not added to
+    // IdResolver, so the code in the OpenMP region uses original variable for
----------------
in the CodeGen -> in CodeGen
Missing space before "This"

http://reviews.llvm.org/D4752






More information about the cfe-commits mailing list