[PATCH] Add [some] template argument-extraction calls to libclang & cindex

Eli Bendersky eliben at google.com
Mon Oct 6 14:52:21 PDT 2014


This looks good; just a couple of nits

================
Comment at: bindings/python/tests/cindex/test_cursor.py:275
@@ +274,3 @@
+
+
+def test_get_template_argument_unsigned_value():
----------------
One empty line here for consistency?

================
Comment at: include/clang-c/Index.h:3016
@@ +3015,3 @@
+ *
+ * If called with I = 1 or 2, 2^32 - 7 or true will be returned, respectively.
+ * For I == 0, an invalid value will be returned or an assert will be triggered.
----------------
I think an example with an actual unsigned would be more useful here :)

http://reviews.llvm.org/D5621






More information about the cfe-commits mailing list