[clang-tools-extra] r219091 - [clang-tidy] Allow space between "TODO" and "(user)"
Alexander Kornienko
alexfh at google.com
Sun Oct 5 16:40:31 PDT 2014
Author: alexfh
Date: Sun Oct 5 18:40:30 2014
New Revision: 219091
URL: http://llvm.org/viewvc/llvm-project?rev=219091&view=rev
Log:
[clang-tidy] Allow space between "TODO" and "(user)"
Modified:
clang-tools-extra/trunk/clang-tidy/google/TodoCommentCheck.cpp
clang-tools-extra/trunk/test/clang-tidy/google-readability-todo.cpp
Modified: clang-tools-extra/trunk/clang-tidy/google/TodoCommentCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/TodoCommentCheck.cpp?rev=219091&r1=219090&r2=219091&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/TodoCommentCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/google/TodoCommentCheck.cpp Sun Oct 5 18:40:30 2014
@@ -19,7 +19,7 @@ class TodoCommentCheck::TodoCommentHandl
public:
TodoCommentHandler(TodoCommentCheck &Check, llvm::Optional<std::string> User)
: Check(Check), User(User ? *User : "unknown"),
- TodoMatch("^// *TODO(\\(.*\\))?:?( )?(.*)$") {}
+ TodoMatch("^// *TODO *(\\(.*\\))?:?( )?(.*)$") {}
bool HandleComment(Preprocessor &PP, SourceRange Range) override {
StringRef Text =
Modified: clang-tools-extra/trunk/test/clang-tidy/google-readability-todo.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/google-readability-todo.cpp?rev=219091&r1=219090&r2=219091&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/google-readability-todo.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/google-readability-todo.cpp Sun Oct 5 18:40:30 2014
@@ -23,3 +23,5 @@
// TODO(bar):
// TODO(foo): paint bikeshed
// TODO(b/12345): find the holy grail
+// TODO (b/12345): allow spaces before parentheses
+// TODO(asdf) allow missing semicolon
More information about the cfe-commits
mailing list