[PATCH] CFE Knob for: Add a thread-model knob for lowering atomics on baremetal & single threaded systems

Tim Northover t.p.northover at gmail.com
Wed Oct 1 17:01:21 PDT 2014


Hi,

The explanation for using posix sounds reasonable to me. Windows users can add win32 as an option later if they need it.

================
Comment at: lib/Driver/Driver.cpp:662-663
@@ +661,4 @@
+  OS << "Thread model: ";
+  if (Arg *A = C.getArgs().getLastArg(options::OPT_mthread_model))
+    OS << A->getValue();
+  else
----------------
Sorry to resurrect a multi-pinged and multi-commented review with another comment, but this would seem to allow "clang -v -mthread-model=silly", wouldn't it? That might be confusing for someone trying to work out what's allowed.

http://reviews.llvm.org/D4985






More information about the cfe-commits mailing list