[PATCH] [OPENMP] Loop collapsing and initial codegen for 'omp simd' directive

hfinkel at anl.gov hfinkel at anl.gov
Tue Sep 30 15:30:09 PDT 2014


LGTM, thanks!

> Regarding 'lastprivate' codegen at: lib/CodeGen/CGStmtOpenMP.cpp:67 -- this will need helper expressions in OMPLastprivateClause (e.g., Copy Constructor to copy from private var to the non-private), this would be better to do in a separate patch.

Okay, please make this clear in the comment (and please add an assert, to be removed later, if the code will be functionally-incorrect without this logic).

================
Comment at: lib/Sema/SemaOpenMP.cpp:2597
@@ +2596,3 @@
+
+  // Choose either 32-bit or 64-bit version.
+  ExprResult LastIteration = LastIteration64;
----------------
Add "the" before 32-bit

http://reviews.llvm.org/D5184






More information about the cfe-commits mailing list