[PATCH] Fix bug 20116 - Miscompilation when devirtualization is aborted due to covariant return types
Bataev, Alexey
a.bataev at hotmail.com
Sun Sep 28 21:31:26 PDT 2014
Richard, Ok, I'll do it
Best regards,
Alexey Bataev
=============
Software Engineer
Intel Compiler Team
27.09.2014 5:40, Richard Smith пишет:
> LGTM with a more detailed testcase.
>
> ================
> Comment at: test/CodeGenCXX/devirtualize-virtual-function-calls-final.cpp:181-184
> @@ -180,6 +180,6 @@
> // not implemented yet.
> + // CHECK: bitcast
> // CHECK: getelementptr
> // CHECK-NEXT: %[[FUNC:.*]] = load
> - // CHECK-NEXT: bitcast
> // CHECK-NEXT: = call {{.*}} %[[FUNC]]
> return static_cast<RA*>(x)->f();
> ----------------
> Can you tweak this test so that it checks the right argument is passed to the function?
>
> http://reviews.llvm.org/D5321
>
>
More information about the cfe-commits
mailing list