[PATCH] Add __sync_fetch_and_nand (again)

[Hal Finkel]

----- Original Message -----
> From: "Joerg Sonnenberger" <joerg at britannica.bec.de>
> To: cfe-commits at cs.uiuc.edu
> Sent: Saturday, September 27, 2014 3:01:56 AM
> Subject: Re: [PATCH] Add __sync_fetch_and_nand (again)
> 
> On Sun, Sep 21, 2014 at 05:00:02PM +0000, hfinkel at anl.gov wrote:
> > It is true, however, that we still set __GNUC_MINOR__ to 2
> > (corresponding to GCC 4.2). To compensate for this, and to address
> > the
> > original concern regarding code relying on the old semantics, I've
> > added a warning in this patch that specifically details the fact
> > that
> > the semantics have changed and that we provide the newer semantics.
> 
> How to disable the warning from code? How to detect the fixed
> semantic?
> IMO without addressing it, we shouldn't readd it.

Agreed, however, the fixed semantics can be detected using the existing Clang version macros. Any code that currently compiles with both GCC and Clang must do something like this anyway (because the intrinsic is not currently provided). Would you prefer a specific feature macro also?

The warning can be disabled by code using the #pragma clang diagnostic directives.

Thanks again,
Hal

> 
> Joerg
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory