[PATCH] [ARM] Handle conflicts between -mfpu and -mfloat-abi options
Renato Golin
renato.golin at linaro.org
Fri Sep 26 03:26:40 PDT 2014
Overall looks good, but I think that this change will also change other ARM architectures (v4~v7) and would be good to add the same login on the prev8 side of things.
Also, can you generate the diff with "-U99" so we can see the rest of the context?
Thanks!
--renato
================
Comment at: lib/Driver/Tools.h:617
@@ -616,3 +616,3 @@
StringRef getARMFloatABI(const Driver &D, const llvm::opt::ArgList &Args,
- const llvm::Triple &Triple);
+ bool *ExplicitNoFloat, const llvm::Triple &Triple);
}
----------------
why not put this at the end of the argument list and make it NULL by default?
http://reviews.llvm.org/D5460
More information about the cfe-commits
mailing list