[PATCH] [ARM] Handle conflicts between -mfpu and -mfloat-abi options

Asiri Rathnayake asiri.rathnayake at arm.com
Thu Sep 25 00:58:58 PDT 2014


>>! In D5460#11, @rmaprath wrote:
>> We shouldn't get rid of -mfloat-abi=softfp, I agree. The warning is relevant there, as this is *also* a hack in GCC.
>> 
> 
> Ok to commit then? The remaining warning is for:
> 
> -mfloat-abi=soft -mfpu=<some_fpu>
> 
> Here we're warning that -mfpu will be ignored, because at the moment -mfloat-abi=soft also means -msoft-float. Perhaps I should get rid of this warning, as the "correct" interpretation of the two flags actual makes sense. WDYT?

Perhaps it's better to remove this warning (from the patch) and interpret this combination as: -mfloat-abi=soft -mhard-float -mfpu=<some_fpu> which is what the original combination really intends to achieve.

Hope this sounds good.

Cheers!

\-\- Asiri

http://reviews.llvm.org/D5460






More information about the cfe-commits mailing list