[PATCH] Fix PR20495: correct inference of the CUDA target for implicit members

Peter Collingbourne peter at pcc.me.uk
Wed Sep 24 18:26:46 PDT 2014


================
Comment at: lib/Sema/SemaDeclCXX.cpp:1
@@ -1,2 +1,1 @@
-//===------ SemaDeclCXX.cpp - Semantic Analysis for C++ Declarations ------===//
 //
----------------
I assume this was a mistake.

================
Comment at: test/SemaCUDA/implicit-member-target.cu:146
@@ +145,3 @@
+
+struct B7_with_copy_assign {
+};
----------------
This should derive from `A7_with_copy_assign`, right?

================
Comment at: test/SemaCUDA/implicit-member-target.cu:150
@@ +149,3 @@
+void hostfoo7() {
+  A7_with_copy_assign a1, a2;
+  a1 = a2;
----------------
Please update this test once your other patch lands and add the other tests Richard asked for.

http://reviews.llvm.org/D5199






More information about the cfe-commits mailing list