[PATCH] [ARM] Handle conflicts between -mfpu and -mfloat-abi options

Asiri Rathnayake asiri.rathnayake at arm.com
Wed Sep 24 06:43:39 PDT 2014


================
Comment at: lib/Driver/Tools.cpp:578
@@ +577,3 @@
+
+  // FIXME: -msoft-float and -mhard-float identify the nature of floating point
+  // ops, whereas -mfloat-abi=... identifies the floating point argument passing
----------------
rengolin wrote:
> I'd rather fix this than warn on inconsistent behaviour of an inconsistent set of flags.
Hi Renato,

Thank you for the comment.

I don't think fixing this will help us get rid of the warnings, because someone can still provide -msoft-float and -mfpu=<fpu_name> even if we separate out the meanings of -mfloat-abi and -msoft-float / -mhard-float on the clang interface.

WDYT?

Thanks.

http://reviews.llvm.org/D5460






More information about the cfe-commits mailing list