r218248 - [mips] Correct alignment of vectors passed in varargs for the O32 ABI.

Daniel Sanders Daniel.Sanders at imgtec.com
Tue Sep 23 02:24:04 PDT 2014


> Why are you running the optimizer at all? This is a test for the code generation of the frontend producing the correct IR, not a test of the optimizer?
>
> If you want to test how the optimizer behaves with a specific set of annotations on IR, that belongs in LLVM's test suite.

It's just to clean up unnecessary alloca's and focus the test on the varargs code.

From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: 23 September 2014 10:15
To: Daniel Sanders
Cc: llvm cfe; Kaelyn Takata
Subject: Re: r218248 - [mips] Correct alignment of vectors passed in varargs for the O32 ABI.


On Tue, Sep 23, 2014 at 2:12 AM, Daniel Sanders <Daniel.Sanders at imgtec.com<mailto:Daniel.Sanders at imgtec.com>> wrote:
> 2) please, please don't use -O3!!! This is *way* too coupled to the inner details of LLVM.

I've switched it down to –O1 in r218298.

Why are you running the optimizer at all? This is a test for the code generation of the frontend producing the correct IR, not a test of the optimizer?

If you want to test how the optimizer behaves with a specific set of annotations on IR, that belongs in LLVM's test suite.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140923/98947046/attachment.html>


More information about the cfe-commits mailing list