[PATCH] [libc++] Support Newlib as libc++'s C library (on ARM) [cmath part, part 1]

Renato Golin renato.golin at linaro.org
Mon Sep 22 18:58:42 PDT 2014


================
Comment at: src/support/newlib/math.cpp:15
@@ +14,3 @@
+#if defined(__arm__) && !defined(__LP64__)
+static_assert(sizeof(long double) == sizeof(double),
+              "These implementations assume: LDBL == DBL");
----------------
jroelofs wrote:
> rengolin wrote:
> > you wont need this assert if you use the same macro as above (double == long double), right? Possibly not even the comment...
> right :)  I think though that the comment makes it clear: these are not an approximation; they precisely implement the required behavior.
good point.

http://reviews.llvm.org/D5419






More information about the cfe-commits mailing list