[PATCH] pass environment when invoking llvm-config, etc. from lit.cfg

Renato Golin renato.golin at linaro.org
Mon Sep 22 10:19:54 PDT 2014


On 22 September 2014 02:59, scott douglass <sdouglass at arm.com> wrote:
> There are places in llvm/test/lit.cfg and clang/test/lit.cfg where
> llvm-config and/or clang are invoked without using config.enviroment which
> means that environment variables like ASAN_OPTIONS, INCLUDE, ... will not be
> available.

Hi Scott,

The change looks really trivial and the right thing to do. LGTM.

I think if you run the full lit tests on more than one platform (x86,
ARM) it should be fine to know that it won't break all the bots, but
there may be some odd-bot (cross, windows) that might break, just keep
an eye for the anomalies.


> [I have sent this to both llvm-commits and cfe-commits because the changes
> are analogous.  My apologies if that was not the right thing to do.]

That's ok, since not all Clang folks are on the LLVM list and vice
versa, and the lists/email clients do a good job at de-duplicating.

Thanks!
--renato



More information about the cfe-commits mailing list