[PATCH] [OPENMP] Codegen for 'firstprivate' clause in 'parallel' directive
hfinkel at anl.gov
hfinkel at anl.gov
Mon Sep 22 01:41:45 PDT 2014
Please separate out the Sema changes from this patch into a separate patch.
================
Comment at: lib/CodeGen/CGExpr.cpp:3483
@@ +3482,3 @@
+
+bool CodeGenFunction::isTrivialInitializer(const Expr *Init) {
+ if (!Init)
----------------
I don't think there is any reason to move this function to a different file. You can update its signature in-place. If you want to move it to a different file for organizational reasons, please do that in a separate commit.
================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:58
@@ +57,3 @@
+ } else {
+ // Perform element-by-element initialization.
+ QualType ElementTy;
----------------
Please extract this into a utility function.
http://reviews.llvm.org/D5140
More information about the cfe-commits
mailing list