[modules][Patch][BugzillaID#20467] Diagnose if -fmodules-cache-path is not writeable

[Vassil Vassilev]

On 17/09/14 21:46, Ben Langmuir wrote:
>>   def err_no_submodule : Error<"no submodule named %0 in module '%1'">;
>> Index: lib/Frontend/CompilerInstance.cpp
>> ===================================================================
>> --- lib/Frontend/CompilerInstance.cpp	(revision 217432)
>> +++ lib/Frontend/CompilerInstance.cpp	(working copy)
>> @@ -339,6 +339,15 @@
>>     if (!getHeaderSearchOpts().DisableModuleHash)
>>       llvm::sys::path::append(SpecificModuleCache,
>>                               getInvocation().getModuleHash());
>> +
>> +  // If the path is not writable we can't do anything but diagnose.
>> +  if (llvm::sys::fs::exists(SpecificModuleCache.str()) &&
>> +       !llvm::sys::fs::can_write(SpecificModuleCache.str())) {
>
> I think this check should only happen if we are building a module, or is there some reason we don’t want to allow read-only module caches when all the modules are prebuilt?
Thanks! It seems I got it all wrong and I lost my reproducer :( I will 
try to come up with a reasonable patch next week.
Vassil
>
> Ben
>
>> On Sep 17, 2014, at 1:04 AM, Vassil Vassilev <vasil.georgiev.vasilev at cern.ch> wrote:
>>
>> Hi,
>>   I am attaching a patch addressing llvm.org/bugs/show_bug.cgi?id=20467
>> Vassil
>>
>> <Bug20467.diff>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


-- 
--------------------------------------------
Q: Why is this email five sentences or less?
A: http://five.sentenc.es