[libcxx patch] Let module.modulemap require cxx_atomics for the atomics module

Nico Weber thakis at chromium.org
Fri Sep 19 18:35:10 PDT 2014


Hi,

when using modules in c++98, libc++ currently fails to build:

While building module 'std' imported from src/disk_interface.h:18:
In file included from <module-includes>:3:
/Users/thakis/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/atomic:539:2:
error: <atomic> is not implemented
#error <atomic> is not implemented
 ^
In file included from src/disk_interface.cc:15:
src/disk_interface.h:18:10: fatal error: could not build module 'std'
#include <map>
 ~~~~~~~~^

The attached patch fixes this by making atomic depend on cxx_atomics. Fixes
PR21002.

Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140919/1febe331/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx-modulemap.patch
Type: application/octet-stream
Size: 334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140919/1febe331/attachment.obj>


More information about the cfe-commits mailing list