Put more stuff in the comdat used for variables with static init

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Sep 18 19:13:20 PDT 2014


On 18 September 2014 21:52, Reid Kleckner <rnk at google.com> wrote:
> The global_ctors patch seems fine, but I think David approved the previous
> patch prematurely.
>
> The initializer code on Windows is already in its own comdat while the
> global_ctors entry is in the comdat with the global. We should leave that as
> is.
>
> I also think you need to put the the global (the key) into a proper comdat,
> and not just leave it as a linkonce_odr global.

Something like this?

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 3129 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140918/393bea9b/attachment.bin>


More information about the cfe-commits mailing list