r218011 - Work around MSVC parser bug by putting redundant braces around the body of

Richard Smith richard at metafoo.co.uk
Thu Sep 18 03:10:41 PDT 2014


Looks like a different issue, I'll investigate in the morning if no one
gets there first.
On Sep 18, 2014 2:57 AM, "Timur Iskhodzhanov" <timurrrr at google.com> wrote:

> I don't think it worked, see my comment on the r217995 commit thread.
>
> 2014-09-18 7:49 GMT+04:00 Richard Smith <richard-llvm at metafoo.co.uk>:
>
>> Author: rsmith
>> Date: Wed Sep 17 22:49:06 2014
>> New Revision: 218011
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=218011&view=rev
>> Log:
>> Work around MSVC parser bug by putting redundant braces around the body of
>> this range-based for loop.
>>
>> Modified:
>>     cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h
>>     cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>>
>> Modified: cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h?rev=218011&r1=218010&r2=218011&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h (original)
>> +++ cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h Wed Sep 17
>> 22:49:06 2014
>> @@ -2146,8 +2146,9 @@ bool RecursiveASTVisitor<Derived>::Trave
>>      }
>>
>>      auto *T = Proto.getTypePtr();
>> -    for (const auto &E : T->exceptions())
>> +    for (const auto &E : T->exceptions()) {
>>        TRY_TO(TraverseType(E));
>> +    }
>>
>>      if (Expr *NE = T->getNoexceptExpr())
>>        TRY_TO(TraverseStmt(NE));
>>
>> Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=218011&r1=218010&r2=218011&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/RecursiveASTVisitor.h (original)
>> +++ cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Wed Sep 17 22:49:06
>> 2014
>> @@ -2168,8 +2168,9 @@ bool RecursiveASTVisitor<Derived>::Trave
>>      }
>>
>>      auto *T = Proto.getTypePtr();
>> -    for (const auto &E : T->exceptions())
>> +    for (const auto &E : T->exceptions()) {
>>        TRY_TO(TraverseType(E));
>> +    }
>>
>>      if (Expr *NE = T->getNoexceptExpr())
>>        TRY_TO(TraverseStmt(NE));
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140918/e2ddc59c/attachment.html>


More information about the cfe-commits mailing list