[PATCH] [libc++] Support newlib as libc++'s C library [locale part]

JF Bastien jfb at chromium.org
Wed Sep 17 17:17:09 PDT 2014


I'm ready to sign off on this after the typos are fixed, but I'd like someone like @mclow.lists to chime in since the `__libcpp_isascii` thing is kind of ugly (but I don't see a better way).

================
Comment at: include/__locale:44
@@ +43,3 @@
+// libc's do, even under __cplusplus. To unify them all, it is wrapped in a shim
+// that has an implementation reserved name. Unfortuantely, beecause glibc has
+// `#define __isascii ...` we can't name it that.
----------------
Two typos :)

================
Comment at: include/locale:199
@@ +198,3 @@
+// include of <sys/cdefs.h> once https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html
+// has had a chance to bake for a bit
+#include <support/newlib/xlocale.h>
----------------
FWIW newlib has yearly releases around Christmas time, so "a bit" may be "quite a bit" ;-)

http://reviews.llvm.org/D5385






More information about the cfe-commits mailing list