[PATCH] [libc++] Support newlib as libc++'s C library [locale part]

JF Bastien jfb at chromium.org
Wed Sep 17 13:32:19 PDT 2014


================
Comment at: include/support/newlib/xlocale.h:27
@@ +26,3 @@
+// duck under that velvet rope.
+int isascii(int c);
+
----------------
`isascii` ins't in C++11 either :-)

Should libc++ not use it at all, or use a special `__isascii`?

================
Comment at: include/support/newlib/xlocale.h:59
@@ +58,3 @@
+
+// Share implementaiton with android bionic
+#include <support/xlocale/xlocale.h>
----------------
typo

http://reviews.llvm.org/D5385






More information about the cfe-commits mailing list