[PATCH] [libc++] Support newlib as libc++'s C library [locale part]

Jonathan Roelofs jonathan at codesourcery.com
Wed Sep 17 12:10:08 PDT 2014


================
Comment at: include/support/newlib/xlocale.h:66
@@ +65,3 @@
+   (void) l;
+   return isdigit(c);
+}
----------------
mclow.lists wrote:
> Should all of these explicitly specify the global namespace?
> 
>     return ::isdigit(c);
> 
> That's not good if isdigit is a macro, but I don't know if that is true for newlib.
All of these are implemented as macros in newlib.

http://reviews.llvm.org/D5385






More information about the cfe-commits mailing list