clang-format: Allow unbroken ::: in inline assembly

Daniel Jasper djasper at google.com
Mon Sep 15 15:10:07 PDT 2014


I think the change itself look good (although I don't use inline assembly
much). Please add a test.

On Mon, Sep 15, 2014 at 11:14 PM, Eugene Toder <eltoder at gmail.com> wrote:

> Hello,
>
> When inline assembly has only clobber constraints it's common to write all
> three colons without spaces, for example:
>
> asm volatile("nop" ::: "memory");
>
> Currently clang-format splits ::: into coloncolon and colon, and inserts a
> space before the colon, which looks strange:
>
> asm volatile("nop" :: : "memory");
>
> I suggest to allow having ::: without spaces in this case. Attached is a
> simple patch to that effect.
>
> Thanks,
> Eugene
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140916/5a1b4d1f/attachment.html>


More information about the cfe-commits mailing list