[PATCH] clang-cl: Warn when a /TC or /TP argument is unused

[Hans Wennborg]

================
Comment at: test/Driver/cl-inputs.c:47
@@ +46,3 @@
+// TPlib2: warning: cl-test.lib: 'linker' input unused
+// TPlib2: warning: argument unused during compilation: '/TP'
+// TPlib2-NOT: cl-test.lib
----------------
ehsan wrote:
> hans wrote:
> > ehsan wrote:
> > > hans wrote:
> > > > Can't you just att this to the TPlib checks above? (And similarly for /TC below.)
> > > No, note the %s in the tests above.  In those tests, /TC and /TP are used on cl-inputs.c.
> > Ah, I didn't notice the %s before.
> > 
> > It still seems that these two tests are very similar. How about dropping the %s above and merging them?
> The first test does ensure that we generate one command for the compilation of cl-inputs.c and the second test doesn't.  I don't think they are quite identical.  But if you think that distinction isn't worth having two separate tests for, I'd be happy to merge them.
Yeah, I don't think that distinction is important.

The way I see it, the important part of the first test is that cl-test.lib doesn't get "compiled".

http://reviews.llvm.org/D5338