[PATCH] clang-cl: Don't treat linker input files differently when /TP or /TC is specified.
Hans Wennborg
hans at chromium.org
Fri Sep 12 11:08:54 PDT 2014
lgtm with nits addressed.
================
Comment at: lib/Driver/Driver.cpp:1080
@@ +1079,3 @@
+ if (!InputTypeArg->getOption().matches(options::OPT_x)) {
+ // If emulating cl.exe, make sure that -TC and -TP don't affect input
+ // object files.
----------------
Nit: I think we've usually spelled the cl.exe style options with slashes in comments.
================
Comment at: test/Driver/cl-inputs.c:39
@@ +38,3 @@
+// TPlib: warning: cl-test.lib: 'linker' input unused
+// TPlib-NOT: cl-test.lib
+
----------------
This should warn that /TP is unused. I'd add a check for that.
http://reviews.llvm.org/D5334
More information about the cfe-commits
mailing list