[PATCH] clang-cl: Don't treat linker input files differently when /TP or /TC is specified.

Hans Wennborg hans at chromium.org
Fri Sep 12 10:57:11 PDT 2014


================
Comment at: lib/Driver/Driver.cpp:1080
@@ -1079,2 +1079,3 @@
         InputTypeArg->claim();
-        Ty = InputType;
+        if (IsCLMode()) {
+          // If emulating cl.exe, make sure that -TC and -TP don't affect input
----------------
hans wrote:
> I would not base this check on what mode we're emulating, but which flag is being used as InputTypeArg, i.e. check that InputTypeArg is now OPT_x.
> 
> Also, we probably shouldn't do InputTypeArg->claim() if we don't end up using it to set the type.
Oops, s/now/not/ in my comment above.

http://reviews.llvm.org/D5334






More information about the cfe-commits mailing list