r217556 - Thread Safety Analysis: major update to thread safety TIL.

[Delesley Hutchins]

Thanks Aaron and Patrick!  Makes sense to me.  :-)  I'm not sure Visited
should be a field of Block at all, so I probably want to remove those in
the next patch anyway.

  -DeLesley


On Fri, Sep 12, 2014 at 5:56 AM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Fri, Sep 12, 2014 at 8:51 AM, Patrik Hägglund H
> <patrik.h.hagglund at ericsson.com> wrote:
> > With gcc-4.9.1, I get:
> >
> > ../tools/clang/lib/Analysis/ThreadSafetyTIL.cpp:173:11: error: overflow
> in implicit constant conversion [-Werror=overflow]
> >    Visited = 1;
> >            ^
> > Should unsigned be used instead of int below?
>
> I just fixed this in r217670 -- I changed to using a bool instead of
> unsigned, since bool is all this is meant to represent anyway.
>
> ~Aaron
>



-- 
DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140912/9f62c25c/attachment.html>