r217546 - Only override the target architecture on -m32 and friends if it is

Tom Stellard tom at stellard.net
Thu Sep 11 13:25:32 PDT 2014


On Thu, Sep 11, 2014 at 10:08:18AM -0700, Hans Wennborg wrote:
> On Wed, Sep 10, 2014 at 2:46 PM, Joerg Sonnenberger
> <joerg at britannica.bec.de> wrote:
> > On Wed, Sep 10, 2014 at 09:25:37PM -0000, Joerg Sonnenberger wrote:
> >> Author: joerg
> >> Date: Wed Sep 10 16:25:37 2014
> >> New Revision: 217546
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=217546&view=rev
> >> Log:
> >> Only override the target architecture on -m32 and friends if it is
> >> actually different. Fixes a surprising link error with nodejs on rpi,
> >> where armv6-netbsd-eabihf turned into armv5e-netbsd-eabihf, which
> >> doesn't lacks the necessary VFP support.
> >
> > This should be merged into the 3.5 branch, but I am not sure who is
> > responsible for maintaining it?
> 
> Tom said he would do 3.5.1.

This looks OK to me, can you get approval from the code owner?

Thanks,
Tom



More information about the cfe-commits mailing list