[PATCH] [libc++abi] Support for __cxa_bad_array_new_length

Dan Albert danalbert at google.com
Thu Sep 11 10:09:51 PDT 2014


I've changed the test so that it calls __cxa_throw_bad_array_new_length()
(I'm mad at whoever gave this function such a long name) directly rather
than expecting the compiler to call it for bad input to new[]. That check
can go in the compiler tests.

On Thu, Sep 11, 2014 at 6:39 AM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Wed, Sep 10, 2014 at 11:52 AM, Dan Albert <danalbert at google.com> wrote:
> > Sorry, I got used to relying on phabricator to keep track of things, and
> > forgot about this one.
>
> No worries!
>
> > Could you split the test in to a separate file and add `// XFAIL: *` at
> the
> > top? That way you can commit it with the guts of the patch and we don't
> have
> > to worry about forgetting to submit the test later.
> >
> > Other than that, LGTM.
>
> I've split the test out into its own file, and have attached the patch
> here.
>
> Since I don't have a way to test this locally, and no other tests have
> XFAIL lines, I'm not quite comfortable committing this without someone
> who can run the tests confirming that it runs cleanly.
>
> Thanks!
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140911/9d50d384/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-of-__cxa_throw_bad_array_new_length.patch
Type: text/x-patch
Size: 3711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140911/9d50d384/attachment.bin>


More information about the cfe-commits mailing list