[PATCH] [libc++abi] Support for __cxa_bad_array_new_length

[Dan Albert]

Sorry, I got used to relying on phabricator to keep track of things, and
forgot about this one.

Could you split the test in to a separate file and add `// XFAIL: *` at the
top? That way you can commit it with the guts of the patch and we don't
have to worry about forgetting to submit the test later.

Other than that, LGTM.

On Wed, Sep 10, 2014 at 5:12 AM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> Ping?
>
> On Thu, Aug 28, 2014 at 5:20 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
> > I apologize for the noise on this thread. It turns out the *original*
> > spelling was __cxa_bad_array_new_length, but the current spelling is
> > __cxa_throw_bad_array_new_length. This patches uses the most current
> > spelling.
> >
> > ~Aaron
> >
> > On Thu, Aug 28, 2014 at 2:52 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
> >> v2 of this patch, this one without tests. Clang does not currently
> >> codegen the correct call to __cxa_bad_array_new_length, so the test
> >> case from the previous patch would result in passing -1 to ::operator
> >> new[], which would then throw a std::bad_alloc, causing the test to
> >> fail. This patch elides the test temporarily, and once Clang codegens
> >> the proper call to __cxa_bad_array_new_length, the test will be
> >> committed for it.
> >>
> >> ~Aaron
> >>
> >> On Thu, Aug 28, 2014 at 2:07 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
> >>> This patch adds support for __cxa_bad_array_new_length, which is
> >>> required for C++11 runtime support to throw std::bad_array_new_length.
> >>>
> >>> Thanks!
> >>>
> >>> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140910/bcf7de86/attachment.html>