[PATCH] Add ACLE predefines: maxmin, rounding and h/w integer division

Tim Northover t.p.northover at gmail.com
Mon Sep 8 02:37:06 PDT 2014


Hi Assad,

On 5 September 2014 12:41, Assad Hashmi <assad.hashmi at arm.com> wrote:
> Note that these are related to Graham Hunter’s patch, (AArch32 v8 NEON
> intrinsics for numeric max/min and directed rounding to integral), and were
> unit tested together.

I think this looks OK. The diff incorporates part of Graham's patch,
though, doesn't it? I'd expect to see just the guards changing in
arm_neon.td otherwise.

Could you make sure it goes in after his changes, rather than before,
for clarity of revision history?

Cheers.

Tim.




More information about the cfe-commits mailing list