[patch] Make "C++98 requires an accessible copy constructor" warning DefaultIgnore

[Nico Weber]

On Sat, Sep 6, 2014 at 5:02 PM, Nico Weber <thakis at chromium.org> wrote:

> On Sat, Sep 6, 2014 at 4:38 PM, Richard Smith <richard at metafoo.co.uk>
> wrote:
>
>> -Wc++98-compat doesn't make sense here: that warning group is for warning
>> on code that is valid in the current language but not in C++98.
>>
>
> The same is true for warn_cxx98_compat_enumerator_list_comma (which is
> in CXX98CompatPedantic) too though, right?
>

…anyhoo, here's a version that just makes this warning an Extension.

I didn't move CXX98CompatBindToTemporaryCopy to CXX98CompatPedanticbecause
that seems like an unrelated change, and because it contradicts the comment
above CXX98CompatPedantic:

// Warnings for C++11 features which are Extensions in C++98 mode.

CXX98CompatBindToTemporaryCopy isn't an Extension, it's a (DefaultIgnored)
Warning. If this gets moved, the comment should be updatend and the other
two (CXX98CompatLocalTypeTemplateArgs, CXX98CompatUnnamedTypeTemplateArgs)
should probably move too? (…but as I said, I think that's unrelated to this
change.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140906/b6aac62a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-bind-to-temp.patch
Type: application/octet-stream
Size: 2160 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140906/b6aac62a/attachment.obj>