[PATCH] [zorg] Clean up libcxx-libcxxabi-singlethreaded-x86_64-linux-debian so that it passes the feature flags to lit

Dan Albert danalbert at google.com
Fri Sep 5 10:45:26 PDT 2014


Other than the quick syntax fixes, LGTM.

================
Comment at: zorg/buildbot/builders/LibcxxAndAbiBuilder.py:73
@@ +72,3 @@
+    if additional_features:
+        litTestArgs = '--param=additional_features=' +
+                      ','.join(additional_features)
----------------
You need to surround the right hand side with () if you split it between two lines.

================
Comment at: zorg/buildbot/builders/LibcxxAndAbiBuilder.py:100
@@ -85,2 +99,3 @@
     # Test libc++abi
+    lit_flags = properties.WithProperties("LIT_ARGS=%s" % litTestArgs)]
     f.addStep(buildbot.steps.shell.ShellCommand(
----------------
Stray ] at EOL.

http://reviews.llvm.org/D5215






More information about the cfe-commits mailing list