r216841 - clang/test/CXX/drs/dr5xx.cpp: Suppress dr547 for targeting MSVC x86 for now, due to incompatibility of attribute(thiscall).

Hans Wennborg hans at chromium.org
Thu Sep 4 18:11:05 PDT 2014


On Thu, Sep 4, 2014 at 5:58 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Thu, Sep 4, 2014 at 4:58 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Sun, Aug 31, 2014 at 5:21 AM, NAKAMURA Takumi <geek4civic at gmail.com>
>> wrote:
>> > Author: chapuni
>> > Date: Sun Aug 31 07:21:50 2014
>> > New Revision: 216841
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=216841&view=rev
>> > Log:
>> > clang/test/CXX/drs/dr5xx.cpp: Suppress dr547 for targeting MSVC x86 for
>> > now, due to incompatibility of attribute(thiscall).
>> >
>> > With targeting i686-win32,
>>
>> I hit the same problem targeting MinGW, so I expanded your fix in r217204.
>
>
> I replaced these with a more directed fix in r217213. I've tested this with
> -target i686-windows-win32, i686-windows-mingw32, and
> x86_64-windows-mingw64. I hope that's sufficient?

I think so. At least all tests pass for me now. Thanks for fixing!



More information about the cfe-commits mailing list