r217213 - Remove suppression of dr547 test and instead test that deduction succeeds if we

[Richard Smith]

Author: rsmith
Date: Thu Sep  4 19:17:00 2014
New Revision: 217213

URL: http://llvm.org/viewvc/llvm-project?rev=217213&view=rev
Log:
Remove suppression of dr547 test and instead test that deduction succeeds if we
use __thiscall. (This doesn't actually work for MSVC; they don't allow the
__thiscall qualifier here, but it's sufficient to demonstrate that we do
implement the intent of the DR.)

Modified:
    cfe/trunk/test/CXX/drs/dr5xx.cpp
    cfe/trunk/www/cxx_dr_status.html

Modified: cfe/trunk/test/CXX/drs/dr5xx.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr5xx.cpp?rev=217213&r1=217212&r2=217213&view=diff
==============================================================================
--- cfe/trunk/test/CXX/drs/dr5xx.cpp (original)
+++ cfe/trunk/test/CXX/drs/dr5xx.cpp Thu Sep  4 19:17:00 2014
@@ -517,17 +517,25 @@ namespace dr546 { // dr546: yes
   template<typename T> void A<T>::f() { T::error; }
 }
 
-// This is incompatible to attribute(thiscall).
-#if !defined(_M_IX86) && !defined(__MINGW32__) && !defined(__MINGW64__)
-namespace dr547 { // d547: yes
+namespace dr547 { // dr547: yes
+  // When targeting the MS ABI, the type of a member function includes a
+  // __thiscall qualifier. This is non-conforming, but we still implement
+  // the intent of dr547
+#if defined(_M_IX86) || defined(__MINGW32__) || defined(__MINGW64__)
+#define THISCALL __thiscall
+#else
+#define THISCALL
+#endif
+
   template<typename T> struct X;
-  template<typename T> struct X<T() const> {};
+  template<typename T> struct X<THISCALL T() const> {};
   template<typename T, typename C> X<T> f(T C::*) { return X<T>(); }
 
   struct S { void f() const; };
-  X<void() const> x = f(&S::f);
+  X<THISCALL void() const> x = f(&S::f);
+
+#undef THISCALL
 }
-#endif
 
 namespace dr548 { // dr548: dup 482
   template<typename T> struct S {};

Modified: cfe/trunk/www/cxx_dr_status.html
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/cxx_dr_status.html?rev=217213&r1=217212&r2=217213&view=diff
==============================================================================
--- cfe/trunk/www/cxx_dr_status.html (original)
+++ cfe/trunk/www/cxx_dr_status.html Thu Sep  4 19:17:00 2014
@@ -3325,7 +3325,7 @@ and <I>POD class</I></td>
     <td><a href="http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#547">547</a></td>
     <td>C++11</td>
     <td>Partial specialization on member function types</td>
-    <td class="none" align="center">Unknown</td>
+    <td class="full" align="center">Yes</td>
   </tr>
   <tr id="548">
     <td><a href="http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_closed.html#548">548</a></td>