r217178 - Win64: Add the uwtable attribute by default on Win64

Reid Kleckner reid at kleckner.net
Thu Sep 4 11:13:12 PDT 2014


Author: rnk
Date: Thu Sep  4 13:13:12 2014
New Revision: 217178

URL: http://llvm.org/viewvc/llvm-project?rev=217178&view=rev
Log:
Win64: Add the uwtable attribute by default on Win64

Now that LLVM emits correct .pdata and .xdata for inline functions, we
can reenable this.

Modified:
    cfe/trunk/lib/Driver/WindowsToolChain.cpp

Modified: cfe/trunk/lib/Driver/WindowsToolChain.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/WindowsToolChain.cpp?rev=217178&r1=217177&r2=217178&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/WindowsToolChain.cpp (original)
+++ cfe/trunk/lib/Driver/WindowsToolChain.cpp Thu Sep  4 13:13:12 2014
@@ -59,11 +59,10 @@ bool Windows::IsIntegratedAssemblerDefau
 }
 
 bool Windows::IsUnwindTablesDefault() const {
-  // FIXME: LLVM's lowering of Win64 data is broken right now.  MSVC's linker
-  // says that our object files provide invalid .pdata contributions.  Until
-  // that is fixed, don't ask for unwind tables.
-  return false;
-  //return getArch() == llvm::Triple::x86_64;
+  // Emit unwind tables by default on Win64. All non-x86_32 Windows platforms
+  // such as ARM and PPC actually require unwind tables, but LLVM doesn't know
+  // how to generate them yet.
+  return getArch() == llvm::Triple::x86_64;
 }
 
 bool Windows::isPICDefault() const {





More information about the cfe-commits mailing list