[PATCH] Don't emit prologues/epilogues for naked functions (PR18791, PR20028)

Hans Wennborg hans at chromium.org
Wed Sep 3 20:32:12 PDT 2014


On Wed, Sep 3, 2014 at 7:42 PM, Nico Weber <thakis at chromium.org> wrote:
> ================
> Comment at: lib/Sema/SemaStmtAsm.cpp:414
> @@ +413,3 @@
> +          Diag(Id.getLocStart(), diag::err_asm_naked_parm_ref);
> +          Diag(Func->getAttr<NakedAttr>()->getLocation(), diag::note_attribute);
> +        }
> ----------------
> Do you need to ` Func->setInvalidDecl();` here too?

Hmm, I don't think so, but I should probably return ExprError() like
other parts of this function does. I'll do that in the next version.

Thanks for noticing!

 - Hans



More information about the cfe-commits mailing list