[PATCH] [libcxx] Add support for building and testing with an ABI library not along linker paths

Ed Maste emaste at freebsd.org
Tue Sep 2 09:06:24 PDT 2014


================
Comment at: lib/CMakeLists.txt:48
@@ +47,3 @@
+if ("${LIBCXX_CXX_ABI_LIBNAME}" STREQUAL "libcxxrt" AND
+    "${CMAKE_SYSTEM}" MATCHES "Linux")
+  append_if(libraries LIBCXX_HAS_DL_LIB dl)
----------------
EricWF wrote:
> emaste wrote:
> > danalbert wrote:
> > > What about FreeBSD? If the BSDs need it too, I think you actually just want to remove the second half of this conditional and let append_if work out this detail.
> > libdl isn't needed on FreeBSD, but that case is already handled by append_if, is it not?
> It's not handled by the append if, but the outer conditional which is only true on linux.
But LIBCXX_HAS_DL_LIB should be false on FreeBSD (and other systems that don't have libdl)

http://reviews.llvm.org/D5038






More information about the cfe-commits mailing list