[PATCH] [libcxx] Add support for building and testing with an ABI library not along linker paths

Eric Fiselier eric at efcs.ca
Mon Sep 1 19:14:40 PDT 2014


================
Comment at: www/index.html:447
@@ +446,3 @@
+        <code>-DCMAKE_LIBRARY_PATH=/path/to/abi/lib</code> when configuring
+        CMake and set <code>RPATH=/path/to/abi/lib</code> when building libc++.
+    </p>
----------------
danalbert wrote:
> Aren't "configuring CMake" and "building libc++" the same thing from the (cmake) user's perspective?
> 
> More importantly, I'm pretty sure we only need one of these. See my comment about find_file().
Hi Dan,

Just wanted to be more clear. The difference between configuring and building is simply the difference between the `cmake` and the `make` command. For CMake we only need the `CMAKE_LIBRARY_PATH` to make `find_library` search along that path. Then we need RPATH when building so that the linker configures libc++.so to look for the ABI library along `RPATH` at runtime.

I can't actually find any instances of `find_file` under libcxxabi. Did you mean `find_program`?
Please let me know if I have misunderstood anything.

http://reviews.llvm.org/D5038






More information about the cfe-commits mailing list