[PATCH] Refactor VariantMatcher::MatcherOps to reduce the amount of generated code.

[Manuel Klimek]

"Needlessly". I don't think making code more complex is worth it. If we can
make the code simpler, I'd be all into it...

On Fri Aug 29 2014 at 12:37:33 PM Nico Weber <thakis at chromium.org> wrote:

> On Fri, Aug 29, 2014 at 12:37 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> On Fri, Aug 29, 2014 at 11:49 AM, Manuel Klimek <klimek at google.com>
>> wrote:
>>
>>> 1. Using /bigobj doesn't seem to be controversial
>>>
>>
>> It catches needlessly large files. (Always this one.) I think that's a
>> good thing.
>>
>
> (Not using it, that is.)
>
>
>>
>>
>>> 2. Can we make the compiler faster on this code?
>>>
>>> I'm still not sure this is worth it. It seems to make the code harder to
>>> maintain.
>>>
>>> http://reviews.llvm.org/D5124
>>>
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140829/7a84a14e/attachment.html>