r216699 - Better codegen support for DLL attributes being dropped after the first declaration (PR20792)

Hans Wennborg hans at chromium.org
Fri Aug 29 10:46:28 PDT 2014


On Thu, Aug 28, 2014 at 7:41 PM, Nico Weber <thakis at chromium.org> wrote:
> On Thu, Aug 28, 2014 at 5:16 PM, Hans Wennborg <hans at hanshq.net> wrote:
>>
>> Author: hans
>> Date: Thu Aug 28 19:16:06 2014
>> New Revision: 216699
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=216699&view=rev
>> Log:
>> Better codegen support for DLL attributes being dropped after the first
>> declaration (PR20792)

[..]

>> This isn't perfect, because we will still get it wrong if the function is
>> never referenced by codegen after the attribute is dropped,
>
>
> Is there a test case for this case?

I committed one in r216749 and also filed PR20803.



More information about the cfe-commits mailing list